Hey @shawnborton, I see this is a [WIP]. Are you wanting to add more icons?

Hey @Luke9389 - thanks for the speedy review! I'm mostly just curious for Andrew's input on what to do for app store descriptions, etc. Stay tuned - we'll let you know if there are more changes coming.

The app store pulls the app icon for some of the listing and then the other part of the listing I have to go and upload manually myself (similar to the app store screenshots)

Okay cool, I think that means we're all good here then.

Hmm I am having a hard time getting the iOS app up and running for testing. Seeing this:

The following build commands failed:
        CompileC /Users/shawnborton/Library/Developer/Xcode/DerivedData/ExpensifyCash-hfttzailbkhegigkkorhlarxjpit/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Flipper-Folly.build/Objects-normal/x86_64/DistributedMutex.o /Users/shawnborton/Expensify/Expensify.cash/ios/Pods/Flipper-Folly/folly/synchronization/DistributedMutex.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Is someone able to help me test?

Maybe this is helpful: facebook/flipper#2215

Have you pulled from master and then reinstalled Pods (cd iOS && rm -rf ./Pods && pod install && cd ..)? That's usually my go-to

Still getting the same error :( going to post in Slack and see if anyone has any ideas.

Oh also doing the same thing with node_modules can be helpful. Total shot in the dark though

@Luke9389 @AndrewGable taking this off hold, but the caveat being that I can't get the Android app to run locally so I have no way of testing this over there. Could either of you two help me out?

Sure, I'll give it a spin 👍

The icons are looking good but my emulator has been stuck on the loading screen (second pick) for a few mins now. Not seeing any errors in the Metro console though. @AndrewGable have you seen this before?

Edit: nvm, forgot ngrok 🤦 . Testing now.

Edit2: Getting tons of 502 errors...

Adding a quick hold to this until some discussion about the timing of this is sorted out.

Closing this one as we are no longer going to use this new icon.

Ok to reopen as part of N6?

I think it's okay to reopen, but perhaps @Luke9389 or someone can help clean this up and take it over the finish line for me?

Hey @shawnborton, happy to pick this up.

So @AndrewGable you mentioned above that you'll need to manually upload this icon to the app store. When should that happen? Do you want to coordinate with me so that this PR gets deployed and the icons get updated at the same time? I can ping you when this is ready for merge.

My game plan for this PR is to clean up the merge conflicts and test on all the platforms.

Good question, I'm not entirely sure the best way to time things but I know we will be changing the name of the app as well, which causes us to push to the app store for this newsletter launch. For more context: https://github.com/Expensify/Expensify/issues/170114

@Luke9389 - Feel free to change/merge any icons, names, colors, etc all in this PR. We will update the assets (including new icons) in the issue @shawnborton linked 👉 https://github.com/Expensify/Expensify/issues/170114 when we publish the app to the "live" store which requires a mobile deployer to configure the release.

OK, I've tested this on all platforms. Gonna assign pullerbear to get this merged.

somehow double-dipped on pullerbear 😬

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging in version: 1.0.77-6🚀

Title:
PR2635 - UI looks different for start page .cash

Expected Result:
The start/login page .cash should be same as shown in PR2635

Actual Result:
UI looks different for start/login page .cash

Action Performed:

1. Launch App

Workaround:
Unknown

Platform:
Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: 1.0.78-0

We recently merged a PR that changed the formatting of the log in page, so everything should be good here.

🚀 Deployed to production in version: 1.0.79-4🚀